fix: updated dns zone name validation logic

[imprateeksh]

Description

There was a small bug in the validation logic where the dns zone name was not expecting any null value. This was seen when consumed this module as an optional value in landing zone.

Issue - 919

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

• Updated the validation logic for DNS Zone name.
• Bumped terraform version to 1.9.0

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[imprateeksh]

/run pipeline

[imprateeksh]

/run pipeline

[rajatagarwal-ibm]

Once this is merged and a new release is created, then make sure to bump SLZ as well, otherwise, all the SLZ PRs will fail until renovate bump them over the weekend.

[imprateeksh]

/run pipeline

[ocofaigh]

The whole point of moving to 1.9 was so you can use cross variable referencing validation, but it seems you did not add any? You need to add validation to ensure that dns_zone_name is not null when user has set enable_hub to true and skip_custom_resolver_hub_creation to flase

[imprateeksh]

The whole point of moving to 1.9 was so you can use cross variable referencing validation, but it seems you did not add any? You need to add validation to ensure that dns_zone_name is not null when user has set enable_hub to true and skip_custom_resolver_hub_creation to flase

I remember the suggestion you told but I thought we will be tackling all cross reference variables in a separate issue. I added one another condition for dns_zone to include cross referencing of variable same as in count.

[imprateeksh]

/run pipeline

[imprateeksh]

/run pipeline

[imprateeksh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 7.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀