Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented May 5, 2025

Description

updated reference-architecture

issue: https://github.ibm.com/GoldenEye/issues/issues/13328

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented May 5, 2025

Updated ref arch diagram:

Screenshot 2025-05-06 at 1 39 57 PM

@Khuzaima05 Khuzaima05 changed the title fix: updated reference arch fix: updated reference architecture diagram May 5, 2025
@Khuzaima05
Copy link
Member Author

Updated ref_arch diagram as per discussion here : https://github.ibm.com/GoldenEye/issues/issues/13668#issuecomment-113064115

Screenshot 2025-05-08 at 1 44 00 PM

@rajatagarwal-ibm
Copy link
Member

rajatagarwal-ibm commented May 8, 2025

In addition to my previous comment, @Khuzaima05, the b in the bucket should be in small letters. Also, make sure it's Flow Logs at all the occurrences.

@Khuzaima05
Copy link
Member Author

In addition to my previous comment, @Khuzaima05, the b in the bucket should be in small letters. Also, make sure it's Flow Logs at all the occurrences.

Done

@Khuzaima05
Copy link
Member Author

Screenshot 2025-05-08 at 2 58 13 PM

@Khuzaima05
Copy link
Member Author

Final ref_arch:

Screenshot 2025-05-14 at 12 02 22 AM

@Khuzaima05
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member

rajatagarwal-ibm commented May 14, 2025

Anomalies still exist in the naming conventions for KMS and Cloud Object Storage. It appears they should follow a similar pattern.

@Khuzaima05
Copy link
Member Author

Closing this PR, Doing the changes in this PR: #998

@Khuzaima05 Khuzaima05 closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants