fix: updated validation for creating subnet

[Khuzaima05]

Description

updated validation for creating subnet

issue: https://ibm-cloudplatform.slack.com/archives/C05QTRFDETY/p1747644785230629

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[Khuzaima05]

/run pipeline

[ocofaigh]

Tests fails with this:

         2025/05/19 11:21:33 Terraform apply | Error: InvalidRequest: Server Side Encryption with hs-crypto is not enabled.
         2025/05/19 11:21:33 Terraform apply | 	status code: 400, request id: 63319a51-d37d-488f-a236-9279851a0d00, host id: 
         2025/05/19 11:21:33 Terraform apply | 
         2025/05/19 11:21:33 Terraform apply |   with module.cos_buckets[0].module.buckets["vpc-da-fl-8fhald-flow-logs-bucket"].ibm_cos_bucket.cos_bucket[0],
         2025/05/19 11:21:33 Terraform apply |   on .terraform/modules/cos_buckets/main.tf line 122, in resource "ibm_cos_bucket" "cos_bucket":
         2025/05/19 11:21:33 Terraform apply |  122: resource "ibm_cos_bucket" "cos_bucket" {

Its unrelated to the changes made in this PR, but will need to be investigated to unblock pipeline

[ocofaigh]

/run pipeline

[Khuzaima05]

/run pipeline

[Khuzaima05]

Tests fails with this:

         2025/05/19 11:21:33 Terraform apply | Error: InvalidRequest: Server Side Encryption with hs-crypto is not enabled.
         2025/05/19 11:21:33 Terraform apply | 	status code: 400, request id: 63319a51-d37d-488f-a236-9279851a0d00, host id: 
         2025/05/19 11:21:33 Terraform apply | 
         2025/05/19 11:21:33 Terraform apply |   with module.cos_buckets[0].module.buckets["vpc-da-fl-8fhald-flow-logs-bucket"].ibm_cos_bucket.cos_bucket[0],
         2025/05/19 11:21:33 Terraform apply |   on .terraform/modules/cos_buckets/main.tf line 122, in resource "ibm_cos_bucket" "cos_bucket":
         2025/05/19 11:21:33 Terraform apply |  122: resource "ibm_cos_bucket" "cos_bucket" {

Its unrelated to the changes made in this PR, but will need to be investigated to unblock pipeline

Pipeline is failing in jp-osa region as jp-osa region does not support COS association with HPCS and hence we are facing that issue with COS bucket creation in JP-OSA region

[Khuzaima05]

/run pipeline

[ocofaigh]

Please either add logic like this to skip that region, or simply hard code to a region for any test with flow logs enabled.

[ocofaigh]

see comments

[Khuzaima05]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 7.23.11 🎉

The release is available on:

• GitHub release
• v7.23.11

Your semantic-release bot 📦🚀