From 67d21beda8e697066f0bccadb8542ebc133c249f Mon Sep 17 00:00:00 2001 From: Vipin Kumar Date: Wed, 30 Jul 2025 23:36:25 +0530 Subject: [PATCH 1/4] docs: vpe security group ids --- ibm_catalog.json | 1 + solutions/fully-configurable/variables.tf | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/ibm_catalog.json b/ibm_catalog.json index d0360497..b0f57091 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -289,6 +289,7 @@ }, { "key": "vpe_gateway_security_group_ids", + "hidden": true, "custom_config": { "grouping": "deployment", "original_grouping": "deployment", diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index 5df0bb2a..4aeca662 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -713,6 +713,12 @@ variable "vpe_gateway_service_endpoints" { } variable "vpe_gateway_security_group_ids" { + + # Currently unused — the DA doesn't create any custom security groups. + # The default security group (automatically created with the VPC) is attached to the VPE gateway since no other security groups are present. + # May be useful in the future when DA supports using an existing VPC with custom security groups. + + description = "List of security group ids to attach to each endpoint gateway." type = list(string) default = null # Let this default value be null instead of []. Provider issue - https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4546 From ab29376c44a04df895bdd09def1ba29d62df2581 Mon Sep 17 00:00:00 2001 From: Vipin Kumar <77929205+Vipin654@users.noreply.github.com> Date: Thu, 31 Jul 2025 19:00:34 +0530 Subject: [PATCH 2/4] Update variables.tf --- solutions/fully-configurable/variables.tf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index 4aeca662..20242661 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -716,8 +716,7 @@ variable "vpe_gateway_security_group_ids" { # Currently unused — the DA doesn't create any custom security groups. # The default security group (automatically created with the VPC) is attached to the VPE gateway since no other security groups are present. - # May be useful in the future when DA supports using an existing VPC with custom security groups. - + # May be useful in the future when DA supports using an existing VPC with custom security groups or if DA supports creating additional security groups. description = "List of security group ids to attach to each endpoint gateway." type = list(string) From 94f0b7e4dbf958dbdef47920281be667c9bd8936 Mon Sep 17 00:00:00 2001 From: Vipin Kumar <77929205+Vipin654@users.noreply.github.com> Date: Thu, 31 Jul 2025 19:09:17 +0530 Subject: [PATCH 3/4] Update variables.tf --- solutions/fully-configurable/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index 20242661..e63b8f3b 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -716,7 +716,7 @@ variable "vpe_gateway_security_group_ids" { # Currently unused — the DA doesn't create any custom security groups. # The default security group (automatically created with the VPC) is attached to the VPE gateway since no other security groups are present. - # May be useful in the future when DA supports using an existing VPC with custom security groups or if DA supports creating additional security groups. + # May be useful in the future when DA supports using an existing VPC with custom security groups or if DA supports creating additional security groups we can take `vpe_gateway_security_group_names` as input. description = "List of security group ids to attach to each endpoint gateway." type = list(string) From d411b24b10cf36497c1f7ed52c95c9157447a3c5 Mon Sep 17 00:00:00 2001 From: Vipin Kumar Date: Fri, 1 Aug 2025 19:14:22 +0530 Subject: [PATCH 4/4] fixed precommit --- solutions/fully-configurable/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index e63b8f3b..5d677f47 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -716,7 +716,7 @@ variable "vpe_gateway_security_group_ids" { # Currently unused — the DA doesn't create any custom security groups. # The default security group (automatically created with the VPC) is attached to the VPE gateway since no other security groups are present. - # May be useful in the future when DA supports using an existing VPC with custom security groups or if DA supports creating additional security groups we can take `vpe_gateway_security_group_names` as input. + # May be useful in the future when DA supports using an existing VPC with custom security groups or if DA supports creating additional security groups we can take `vpe_gateway_security_group_names` as input. description = "List of security group ids to attach to each endpoint gateway." type = list(string)