-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Migration to landing zone VPC DA #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are required, as per the discussion in DA rally. Please check rally recording for more details. Some of those are:
- * dependencies description
- * diagram labels
- * change variation name
- * some changes in fully configurable DA diagram
|
FYI, #1040 should be merged before this one please |
|
@Aditya-ranjan-16 Can you resolve conflicts now that dependant PR is merged - lets see if we can get this one merged today |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aditya-ranjan-16 I think we need to update addon test to use landing zone tile:
[TestVpcAddonDefaultConfiguration] CRITICAL ERROR: Error importing the offering: Unable to preprocess repo content: Error[400 Bad Request] - Could not find a product named 'deploy-arch-ibm-vpc' with product kind deployable architecture (solution) in the specified catalog manifest
updated |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
Failure unrelated to changes in this PR, re-running.. |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
🎉 This PR is included in version 8.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
https://github.ibm.com/GoldenEye/issues/issues/14047
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers