ci: remove usage template from ibm_catalog.json (#607)

Author: ocofaigh

.secrets.baseline

@@ -3,7 +3,7 @@
     "files": "go.sum|^.secrets.baseline$",
     "lines": null
   },
-  "generated_at": "2023-09-07T10:17:11Z",
+  "generated_at": "2023-10-13T15:23:43Z",
   "plugins_used": [
     {
       "name": "AWSKeyDetector"
@@ -77,16 +77,6 @@
     }
   ],
   "results": {
-    "ibm_catalog.json": [
-      {
-        "hashed_secret": "83b1c425484475e97934007eccb2277e9bdbd203",
-        "is_secret": false,
-        "is_verified": false,
-        "line_number": 921,
-        "type": "Secret Keyword",
-        "verified_result": null
-      }
-    ],
     "module-metadata.json": [
       {
         "hashed_secret": "9e015cae2bac80e09c9d422c91b0c2c83e883cb0",

cra-tf-validate-ignore-rules.json

@@ -5,6 +5,12 @@
             "description": "Check whether Cloud Object Storage network access is restricted to a specific IP range",
             "ignore_reason": "In order for this rule to pass, Context Based Restrictions (CBRs) support needs to be added to the module (tracking in https://github.ibm.com/GoldenEye/issues/issues/5626). Even after that is added, there is still a dependency on SCC to support scanning for CBR rules. SCC CBR support is being tracked in https://github.ibm.com/project-fortress/pm/issues/11800.",
             "is_valid": true
+        },
+        {
+             "scc_rule_id": "rule-216e2449-27d7-4afc-929a-b66e196a9cf9",
+             "description": "Check whether Flow Logs for VPC are enabled",
+             "ignore_reason": "This rule should not be failing as we do enable flow logs in the code. Bug reported with CRA: https://github.ibm.com/oneibmcloud/CD-CRA/issues/1907",
+             "is_valid": false
         }
     ]
 }

ibm_catalog.json

@@ -50,7 +50,6 @@
                     "name": "quickstart",
                     "install_type": "fullstack",
                     "working_directory": "patterns/vsi-quickstart",
-                    "usage_template": "module \"landing-zone\" {\n  source           = \"https://cm.globalcatalog.cloud.ibm.com/api/v1-beta/offering/source//${{workingDirectory}}?archive=tgz&flavor=${{flavor}}&kind=terraform&name=${{name}}&version=${{version}}\"\n  ibmcloud_api_key = var.ibmcloud_api_key\n  ssh_key   = var.ssh_key\n  region           = \"us-south\"\n  prefix           = \"slz\"\n}\n\n",
                     "compliance": {},
                     "configuration": [
                         {
@@ -175,7 +174,6 @@
                     "name": "standard",
                     "install_type": "fullstack",
                     "working_directory": "patterns/vsi",
-                    "usage_template": "module \"landing-zone\" {\n  source           = \"https://cm.globalcatalog.cloud.ibm.com/api/v1-beta/offering/source//${{workingDirectory}}?archive=tgz&flavor=${{flavor}}&kind=terraform&name=${{name}}&version=${{version}}\"\n  ibmcloud_api_key = var.ibmcloud_api_key\n  ssh_public_key   = var.ssh_public_key\n  region           = \"us-south\"\n  prefix           = \"slz\"\n}\n\n",
                     "compliance": {
                         "authority": "scc-v3",
                         "profiles": [
@@ -552,7 +550,6 @@
                     "name": "standard",
                     "install_type": "fullstack",
                     "working_directory": "patterns/vpc",
-                    "usage_template": "module \"landing-zone-vpc\" {\n  source           = \"https://cm.globalcatalog.cloud.ibm.com/api/v1-beta/offering/source//${{workingDirectory}}?archive=tgz&flavor=${{flavor}}&kind=terraform&name=${{name}}&version=${{version}}\"\n  ibmcloud_api_key = var.ibmcloud_api_key\n  region           = \"us-south\"\n  prefix           = \"slz-vpc\"\n}\n\n",
                     "compliance": {
                         "authority": "scc-v3",
                         "profiles": [
@@ -918,7 +915,6 @@
                     "name": "standard",
                     "install_type": "fullstack",
                     "working_directory": "patterns/roks",
-                    "usage_template": "module \"landing-zone\" {\n  source           = \"https://cm.globalcatalog.cloud.ibm.com/api/v1-beta/offering/source//patterns/roks?archive=tgz&flavor=${{flavor}}&kind=terraform&name=${{name}}&version=${{version}}\"\n  ibmcloud_api_key = var.ibmcloud_api_key\n  region           = \"us-south\"\n  prefix           = \"slz\"\n}\n\n",
                     "compliance": {
                         "authority": "scc-v3",
                         "profiles": [