Skip to content

Conversation

@kierramarie
Copy link
Member

@kierramarie kierramarie commented Jun 9, 2025

Description

Exposed retention_rule in base module and added retention_rule to the patterns' override.json.

Git Issue: #978

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie kierramarie marked this pull request as ready for review June 10, 2025 22:38
@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

Latest errors:

2025-06-16T19:16:29.3976853Z TestRunUpgradeROKSQuickStartPattern 2025-06-16T19:16:29Z command.go:206: �[31m│ summary: 'timeout while waiting for state to become ''deleted'' (last
2025-06-16T19:16:29.3978373Z TestRunUpgradeROKSQuickStartPattern 2025-06-16T19:16:29Z command.go:206: �[31m│ state: ''deleting'',

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

@daniel-butler-irl daniel-butler-irl merged commit ceb785d into main Jun 25, 2025
2 checks passed
@daniel-butler-irl daniel-butler-irl deleted the ks-cos-ret branch June 25, 2025 09:14
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants