Skip to content

Conversation

@akocbek
Copy link
Contributor

@akocbek akocbek commented Jul 28, 2025

Description

Update dropdown box with values. Reference values https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/ibm_catalog.json

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@akocbek
Copy link
Contributor Author

akocbek commented Jul 28, 2025

/run pipeline

"key": "kube_version",
"type": "string",
"required": true,
"options": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also an option to specify the string "default"? At least at the terraform side? this will deploy whatever the latest default IBM Cloud cluster version is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm - I thought we purposely didn't expose Default as an option? And forced user to explicitly pick a version. We would have a default value in here which ideally would match the version that is current IKS default

@akocbek
Copy link
Contributor Author

akocbek commented Jul 30, 2025

/run pipeline

@akocbek akocbek merged commit 8cc4c7c into main Jul 30, 2025
2 checks passed
@akocbek akocbek deleted the update branch July 30, 2025 20:01
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

},
{
"key": "flavor"
"key": "flavor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm - this is going to be tricky to maintain. Are we even sure all of these values are supported for every OS, every version and every region?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants