-
Notifications
You must be signed in to change notification settings - Fork 37
fix: update ibm_catalog json to use dropdown picker #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
| "key": "kube_version", | ||
| "type": "string", | ||
| "required": true, | ||
| "options": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also an option to specify the string "default"? At least at the terraform side? this will deploy whatever the latest default IBM Cloud cluster version is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm - I thought we purposely didn't expose Default as an option? And forced user to explicitly pick a version. We would have a default value in here which ideally would match the version that is current IKS default
|
/run pipeline |
|
🎉 This PR is included in version 8.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
| }, | ||
| { | ||
| "key": "flavor" | ||
| "key": "flavor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm - this is going to be tricky to maintain. Are we even sure all of these values are supported for every OS, every version and every region?
Description
Update dropdown box with values. Reference values https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/ibm_catalog.json
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers