-
Notifications
You must be signed in to change notification settings - Fork 36
fix: updated reference architecture of roks DA using the latest guidelines & stencils #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
maheshwarishikha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Subnets are wrongly copied. Please verify all the subnets with the original diagram carefully.
- According to me Zones should be a solid line box instead of dotted line. Reference diagram also has the same.
maheshwarishikha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maheshwarishikha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we have two cluster Management OpenShift Cluster and Workload OpenShift cluster - these names are removed in the new diagram.
Either add it as cluster or for worker nodes. Info should not miss in transition of diagram.
Done, Updated to specific naming of clusters. |
|
vburckhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a minor comment - some icons are not aligned horizontally (openshift worker nodes)
|
/run pipeline |
Updated |
|
/run pipeline |
maheshwarishikha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/run pipeline |
|
🎉 This PR is included in version 8.5.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |



Description
issue: https://github.ibm.com/GoldenEye/issues/issues/15554
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers