Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Aug 19, 2025

Description

issue: https://github.ibm.com/GoldenEye/issues/issues/15554

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 changed the title feat: updated ref arch diagram fix: updated reference architecture of roks DA using the latest guidelines & stencils Aug 19, 2025
@Khuzaima05 Khuzaima05 self-assigned this Aug 19, 2025
@Khuzaima05 Khuzaima05 marked this pull request as ready for review August 20, 2025 04:35
Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Subnets are wrongly copied. Please verify all the subnets with the original diagram carefully.
  • According to me Zones should be a solid line box instead of dotted line. Reference diagram also has the same.

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some additional box, please check.
image

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we have two cluster Management OpenShift Cluster and Workload OpenShift cluster - these names are removed in the new diagram.
Either add it as cluster or for worker nodes. Info should not miss in transition of diagram.

@Khuzaima05
Copy link
Member Author

Also, we have two cluster Management OpenShift Cluster and Workload OpenShift cluster - these names are removed in the new diagram. Either add it as cluster or for worker nodes. Info should not miss in transition of diagram.

Done, Updated to specific naming of clusters.

@Khuzaima05
Copy link
Member Author

There is some additional box, please check. image

Removed

@Khuzaima05
Copy link
Member Author

  • Subnets are wrongly copied. Please verify all the subnets with the original diagram carefully.
  • According to me Zones should be a solid line box instead of dotted line. Reference diagram also has the same.
Screenshot 2025-08-21 at 12 49 14 PM

vburckhardt
vburckhardt previously approved these changes Aug 21, 2025
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a minor comment - some icons are not aligned horizontally (openshift worker nodes)

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

Looks good - just a minor comment - some icons are not aligned horizontally (openshift worker nodes)

Updated

@Khuzaima05
Copy link
Member Author

/run pipeline

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khuzaima05
Copy link
Member Author

/run pipeline

@maheshwarishikha maheshwarishikha merged commit bd97097 into main Aug 21, 2025
0 of 2 checks passed
@maheshwarishikha maheshwarishikha deleted the 15554 branch August 21, 2025 15:30
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants