Skip to content

fix: review of module #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 30, 2025
Merged

fix: review of module #1058

merged 12 commits into from
Sep 30, 2025

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Sep 11, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Sep 11, 2025
@jor2
Copy link
Member Author

jor2 commented Sep 11, 2025

Screenshot 2025-09-11 at 10 54 19 Screenshot 2025-09-11 at 10 54 49

@jor2
Copy link
Member Author

jor2 commented Sep 11, 2025

Screenshot 2025-09-11 at 10 56 16

@jor2 jor2 requested a review from ocofaigh September 11, 2025 09:56
ocofaigh
ocofaigh reviewed Sep 11, 2025
View reviewed changes
ocofaigh
ocofaigh requested changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@jor2 jor2 requested a review from ocofaigh September 12, 2025 12:44
@jor2
Copy link
Member Author

jor2 commented Sep 15, 2025

Screenshot 2025-09-15 at 17 26 14

@jor2
Copy link
Member Author

jor2 commented Sep 15, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Sep 22, 2025

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Sep 24, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Sep 29, 2025

/run pipeline

ocofaigh
ocofaigh requested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@jor2
Copy link
Member Author

jor2 commented Sep 30, 2025

/run pipeline

@toddgiguere toddgiguere merged commit dceb7e0 into main Sep 30, 2025
2 checks passed
@toddgiguere toddgiguere deleted the update-pickers branch September 30, 2025 19:06
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Sep 30, 2025

🎉 This PR is included in version 8.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@toddgiguere toddgiguere Awaiting requested review from toddgiguere

@Aashiq-J Aashiq-J Awaiting requested review from Aashiq-J Aashiq-J is a code owner

Assignees

@jor2 jor2

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jor2 @terraform-ibm-modules-ops @ocofaigh @toddgiguere