bug in default override json

[ocofaigh]

The override.json files in the patterns all have a bug in them:

"archive_rule": {
  "rule_id": "a-bucket-arch-rule",
  "enable": true,
  "days": 0,
  "type": "GLACIER"
}

This will give the error:

Seems the expected value it Glacier and not all caps like in the override json GLACIER

[ocofaigh]

@akocbek look like you added this in #687 so assigning to you

[ocofaigh]

@akocbek it looks like you have set other things in the override.json that should not be set. The override json should always be set up to the default values, but I see you added things like "allowed_ip": ["10.10.10.10/24"] which we should not have as a default value.

[akocbek]

#704

[akocbek]

we had to remove activity_tracking and metrics_monitoring because they require valid CRN (e.q. activity_tracker_crn) which we don't have it at that stage. If we remove activity_tracker_crn or metrics_monitoring_crn only then we get the following:

│ The given value is not suitable for module.roks_landing_zone.module.landing_zone.var.cos declared at ../../variables.tf:480,1-15: element 0: attribute "buckets": element 0: attribute "metrics_monitoring":
│ attribute "metrics_monitoring_crn" is required.