Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jan 29, 2025

Description

#942

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jan 29, 2025
@jor2
Copy link
Member Author

jor2 commented Jan 29, 2025

/run pipeline

@jor2 jor2 changed the title feat: Migrate to ibm_cos_lifecycle_configuration SKIP UPGRADE TESTS feat: Migrate to ibm_cos_lifecycle_configuration Feb 13, 2025
@jor2
Copy link
Member Author

jor2 commented Feb 13, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Feb 13, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Feb 14, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Feb 14, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Feb 17, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Feb 19, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Feb 19, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill need to see the result of an upgrade test before I can approve. The upgrade test should not of been skipped on the first commit.
If indeed the upgrade test only finds the update of the bucket, then I am fine to skip and approve, but we have no proof of that currently as it never ran. Suggest to locally run the VPC upgrade test and paste the evidence in this PR.

@jor2
Copy link
Member Author

jor2 commented Feb 20, 2025

/run pipeline

@ocofaigh ocofaigh merged commit db96a4b into main Feb 20, 2025
2 checks passed
@ocofaigh ocofaigh deleted the deprecation branch February 20, 2025 09:52
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants