Stop creating COS VPE

[ocofaigh]

Description

IKS already create the required VPE upon cluster creation. Landing zone VPE is now conflicting with the IKS one, and the landing zone one does not the required inbound rule to allow workers to reach it, so cluster goes into a warning state.

Proposed solution in this PR:

• Stop creating COS VPE

Open questions:

• Should we also remove the logic that created the VPE security group here?
• Should we continue to create the dedicated VPE subnets (I think for now yes?)

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

Need to merge #955 first

[ocofaigh]

/run pipeline

[ocofaigh]

As expected the upgrade test failed since it want to destroy the COS VPE:

2025-02-20T10:55:05.1270613Z         	Messages:   	Resource(s) identified to be destroyed 
2025-02-20T10:55:05.1270948Z         	            	Name: ip
2025-02-20T10:55:05.1271526Z         	            	Address: module.vpc_landing_zone.module.landing_zone.ibm_is_subnet_reserved_ip.ip["workload-cos-gateway-vpe-zone-3-ip"]
2025-02-20T10:55:05.1272122Z         	            	Actions: [delete]

It also destroys the reserved IP:

2025-02-20T10:55:05.1394669Z         	Messages:   	Resource(s) identified to be destroyed 
2025-02-20T10:55:05.1395162Z         	            	Name: ip
2025-02-20T10:55:05.1396153Z         	            	Address: module.vpc_landing_zone.module.landing_zone.ibm_is_subnet_reserved_ip.ip["management-cos-gateway-vpe-zone-3-ip"]
2025-02-20T10:55:05.1397155Z         	            	Actions: [delete]

going to skip upgrade test

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

• GitHub release
• v7.2.0

Your semantic-release bot 📦🚀