Skip to content

Conversation

@arya-girish-k
Copy link
Contributor

@arya-girish-k arya-girish-k commented May 7, 2025

Description

Review DA inputs to align with best practices
Git_issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  1. Reordered and grouped the variables in ibm catalog.json in all DA's(vsi,vpc,roks,roks-quickstart,vsi-extension,vsi-quickstart)

  2. Added custom_config for tags(tags,resource,access) input in all DA's.
    image

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k arya-girish-k marked this pull request as draft May 7, 2025 02:42
@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k arya-girish-k marked this pull request as ready for review May 7, 2025 09:47
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change back all the F5 variable renames - There are all hidden anyway and we don't officially support it. So lets not change them and avoid confusion

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

can you change back all the F5 variable renames - There are all hidden anyway and we don't officially support it. So lets not change them and avoid confusion

Reverted the variables.

@arya-girish-k arya-girish-k requested a review from ocofaigh May 9, 2025 06:03
@ocofaigh ocofaigh merged commit c5f8d3e into main May 12, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 11571-issue branch May 12, 2025 09:24
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.4.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants