Skip to content

Conversation

@mukulpalit-ibm
Copy link
Contributor

Description

  • terraform version upgrade to 1.9.0
  • migrated validation from patterns/mixed/config.tf, patterns/vsi/module/config.tf and patterns/vsi-extension/config.tf to variables.tf

Test Cases :

override override_json_string ssh_public_key existing_ssh_key_name result
false "" "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC1examplekey" null
false "" null "my-key-name"
true "" null null
false "{"some": "value"}" null null
false "{"some": "value"}" "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC1examplekey" "my-key-name"
false "" null null

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aashiq-J Aashiq-J merged commit 17a4c1a into main May 16, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the 12409-cross-object-referencing branch May 16, 2025 06:44
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants