Skip to content

Conversation

@Aditya-ranjan-16
Copy link
Contributor

Description

https://github.ibm.com/GoldenEye/issues/issues/14047

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16 Aditya-ranjan-16 marked this pull request as ready for review August 25, 2025 14:41
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 3, 2025

@Aditya-ranjan-16 Please let me know when all the changes in #1045 are part of this PR too

@Aditya-ranjan-16
Copy link
Contributor Author

@ocofaigh #1045 changes are added , and PR also synced with terraform-ibm-modules/terraform-ibm-landing-zone-vpc#1042

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 42decc4 into main Sep 4, 2025
2 checks passed
@ocofaigh ocofaigh deleted the vpc-migration branch September 4, 2025 09:32
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.5.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants