Replace `logs_agent_additional_log_source_paths` with new input `logs_agent_system_logs`

[ocofaigh]

Remove the logs_agent_additional_log_source_paths option from the module and DA, and replace it with new input called logs_agent_system_logs. The associated helm value for this input is called systemLogs (see internal docs).

Background:

if you use the additionalLogSourcePaths pointing to paths outside of /var/log/containers, then the agent will spit out a ton of logs and it seems those logs are contributing to memory growth and eventually causing OOM on the fluentbit container.

However, we introduced a new configuration named systemLogs that you should use for the non-kube logs - for example :

systemLogs:
  - /var/log/kube-proxy.log
  - /var/log/kubelet.log

and this will avoid sending the logs through the kubernetes filter and will instead flow through a second tail input plugin.

so the recommendation is to :
stop using additionalLogSourcePaths - there’s no good reason that I can think of to use this setting any more
start using systemLogs

if you want to limit the container logs that you are processing, use the selectedLogSourcePaths or excludeLogSourcePaths to limit the set of container logs to be processed

[kierramarie]

PR merged. Closing issue.