feat: add support for SHA #154
Conversation
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
Needs to be exposed in the DA too
| name = "image.version" | ||
| type = "string" | ||
| value = var.logs_agent_image_version | ||
| value = split("@", var.logs_agent_image_version)[0] |
There was a problem hiding this comment.
hmm, did you check what happens when image.version and image.containerSha are both being passed? Will SHA take precedence?
There was a problem hiding this comment.
image version is always required.
Here is the logic which the observability team implemented to use the SHA digest
https://github.ibm.com/Observability/helm-charts/blob/5a08774693cfd18c66cbf4e88e6f0cbbcbacd353/logs-agent/templates/_helpers.tpl#L46
If the user passes the sha they just append it to the version.
There was a problem hiding this comment.
ah I see - so thats why we need to remove it in our code - thanks
|
/run pipeline |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
logs agent images now support passing SHA values but since the values for the init and main container are different, we had to take the approach in this PR
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers