Skip to content

feat: Add Support to enable multiline #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 23, 2025
Merged

feat: Add Support to enable multiline #64

merged 7 commits into from
May 23, 2025

Conversation

@arya-girish-k
Copy link
Contributor

@arya-girish-k arya-girish-k commented May 22, 2025

Description

Added Support to enable multiline in the DA.
Git_issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Exposed helm value called enableMultiline in the module and the DA.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 22, 2025

/run pipeline

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 22, 2025

/run pipeline

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 22, 2025

Tested the helm value enableMultiline. When enableMultiline=true, the generated ConfigMap includes the @include filter-multiline.conf line. PFA screenshot.
image

Aashiq-J
Aashiq-J reviewed May 22, 2025
View reviewed changes
Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you check what if you set the value to false, will the @INCLUDE filter-multiline.conf be added?

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 22, 2025 •
edited
Loading

Also can you check what if you set the value to false, will the @INCLUDE filter-multiline.conf be added?

When enableMultiline=false,@include filter-multiline.conf will not be added
image

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 22, 2025

/run pipeline

@arya-girish-k arya-girish-k requested a review from Aashiq-J May 22, 2025 15:28
@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 23, 2025

/run pipeline

Aashiq-J
Aashiq-J previously approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ocofaigh
ocofaigh requested changes May 23, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the variable descriptions with the official doc link so users can learn more about multiline logs

@arya-girish-k @ocofaigh
Update variables.tf
9b2b48c 
Co-authored-by: Conall Ó Cofaigh <[email protected]>
@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 23, 2025

/run pipeline

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented May 23, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 5419bd2 into main May 23, 2025
2 checks passed
@ocofaigh ocofaigh deleted the logs-agent branch May 23, 2025 17:09
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented May 23, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@Aashiq-J Aashiq-J Aashiq-J left review comments

@shemau shemau Awaiting requested review from shemau

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arya-girish-k @terraform-ibm-modules-ops @ocofaigh @Aashiq-J