update DA

Author: Aashiq-J

README.md

@@ -149,7 +149,7 @@ No modules.
 | <a name="input_metrics_filter"></a> [metrics\_filter](#input\_metrics\_filter) | To filter custom metrics you can specify which metrics to include and exclude. For more info, see https://cloud.ibm.com/docs/monitoring?topic=monitoring-change_kube_agent#change_kube_agent_inc_exc_metrics | <pre>list(object({<br/>    include = optional(string)<br/>    exclude = optional(string)<br/>  }))</pre> | `[]` | no |
 | <a name="input_name"></a> [name](#input\_name) | The name to give the agent helm release. | `string` | `"sysdig-agent"` | no |
 | <a name="input_namespace"></a> [namespace](#input\_namespace) | Namespace to deploy the agent to. | `string` | `"ibm-observe"` | no |
-| <a name="input_priority_class_name"></a> [priority\_class\_name](#input\_priority\_class\_name) | Sets the priority class name for the agent daemonset. | `string` | `"sysdig-daemonset-priority"` | no |
+| <a name="input_priority_class_name"></a> [priority\_class\_name](#input\_priority\_class\_name) | Sets the priority class name for the agent daemonset. | `string` | `null` | no |
 | <a name="input_priority_class_value"></a> [priority\_class\_value](#input\_priority\_class\_value) | Sets the priority class value for the agent daemonset. | `number` | `10` | no |
 | <a name="input_prometheus_config"></a> [prometheus\_config](#input\_prometheus\_config) | Prometheus configuration for the agent. If you want to enable Prometheus configuration provide the prometheus.yaml file content in `hcl` format. [Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-monitoring-agent/blob/main/solutions/fully-configurable/DA-types.md#prometheus_config). | `map(any)` | `{}` | no |
 | <a name="input_tolerations"></a> [tolerations](#input\_tolerations) | List of tolerations to apply to the agent. | <pre>list(object({<br/>    key               = optional(string)<br/>    operator          = optional(string)<br/>    value             = optional(string)<br/>    effect            = optional(string)<br/>    tolerationSeconds = optional(number)<br/>  }))</pre> | <pre>[<br/>  {<br/>    "operator": "Exists"<br/>  },<br/>  {<br/>    "effect": "NoSchedule",<br/>    "key": "node-role.kubernetes.io/master",<br/>    "operator": "Exists"<br/>  }<br/>]</pre> | no |

examples/obs-agent-iks/main.tf

@@ -145,6 +145,8 @@ module "monitoring_agents" {
   is_vpc_cluster            = var.is_vpc_cluster
   access_key                = module.cloud_monitoring.access_key
   instance_region           = var.region
+  create_priority_class     = true
+  priority_class_name       = "test"
   prometheus_config = {
     scrape_configs = [
       {

main.tf

@@ -253,7 +253,7 @@ resource "helm_release" "cloud_monitoring_agent" {
       ${line}
 %{endfor~}
   "createPriorityClass": ${var.create_priority_class}
-  "priorityClassName": ${var.priority_class_name}
+  "priorityClassName": ${var.priority_class_name == null ? "null" : var.priority_class_name}
   "priorityClassValue": ${var.priority_class_value}
   "daemonset":
     "updateStrategy":

solutions/fully-configurable/main.tf

@@ -53,4 +53,9 @@ module "monitoring_agent" {
   cluster_shield_limits_cpu       = var.cluster_shield_limits_cpu
   cluster_shield_requests_memory  = var.cluster_shield_requests_memory
   cluster_shield_limits_memory    = var.cluster_shield_limits_memory
+  max_unavailable                 = var.max_unavailable
+  max_surge                       = var.max_surge
+  create_priority_class           = var.create_priority_class
+  priority_class_name             = var.priority_class_name
+  priority_class_value            = var.priority_class_value
 }

solutions/fully-configurable/variables.tf

@@ -245,6 +245,37 @@ variable "deployment_tag" {
   default     = "terraform"
 }
 
+variable "max_unavailable" {
+  type        = string
+  description = "Maximum number of pods that can be unavailable during a DaemonSet rolling update. Accepts absolute number or percentage (e.g., '1' or '10%')."
+  default     = "1"
+}
+
+variable "max_surge" {
+  type        = string
+  description = "Maximum number of nodes that can have an extra DaemonSet pod during a rolling update. Accepts absolute number or percentage (e.g., '1' or '10%')."
+  default     = null
+}
+
+variable "create_priority_class" {
+  type        = bool
+  description = "Specify whether or not to create a priority class for the agent daemonset."
+  default     = false
+}
+
+variable "priority_class_name" {
+  type        = string
+  description = "Sets the priority class name for the agent daemonset."
+  default     = "sysdig-daemonset-priority"
+  nullable    = false
+}
+
+variable "priority_class_value" {
+  type        = number
+  description = "Sets the priority class value for the agent daemonset."
+  default     = 10
+}
+
 ##############################################################################
 # Metrics related variables
 ##############################################################################

variables.tf

@@ -269,7 +269,6 @@ variable "max_surge" {
   }
 }
 
-
 variable "create_priority_class" {
   type        = bool
   description = "Specify whether or not to create a priority class for the agent daemonset."
@@ -279,8 +278,12 @@ variable "create_priority_class" {
 variable "priority_class_name" {
   type        = string
   description = "Sets the priority class name for the agent daemonset."
-  default     = "sysdig-daemonset-priority"
-  nullable    = false
+  default     = null
+
+  validation {
+    condition     = var.create_priority_class ? var.priority_class_name == null ? false : true : true
+    error_message = "When 'create_priority_class' is set to true, a value for 'priority_class_name' should be passed."
+  }
 }
 
 variable "priority_class_value" {