Skip to content

Conversation

@yuvraj-singh-3
Copy link
Contributor

Description

Git issue: #153

Add support for custom prometheus scrape_configs in sysdig-agent configmap. Ref: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#configuration-file

This is supported in agent's configmap and then configured in values.yaml

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor

Please give me some time to try this out. I'll have to push some extra updates to this PR:

  • address failing pre-commit hooks
  • expose in the DA (which will need a supporting markdown doc for the complex input)
  • update one of the tests to test this feature

@ocofaigh
Copy link
Contributor

Covered in #167

@ocofaigh ocofaigh closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants