fix: added validation for metrics_filter #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For this wrong input, And for the correct input, |
Contributor
Author
|
/run pipeline |
…form-ibm-monitoring-agent into 15161_add-validation
Contributor
Author
|
/run pipeline |
3 similar comments
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
…form-ibm-monitoring-agent into 15161_add-validation
…form-ibm-monitoring-agent into 15161_add-validation
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Aashiq-J
reviewed
Jul 30, 2025
variables.tf
Outdated
| ) | ||
| ) | ||
| ]) | ||
| error_message = "Each item in 'metrics_filter' must have either 'include' or 'exclude' set (not both, not neither), and the value must not be null or empty." |
Member
There was a problem hiding this comment.
[] empty list is a valid value, update the error message.
…form-ibm-monitoring-agent into 15161_add-validation
Contributor
Author
|
/run pipeline |
Aashiq-J
approved these changes
Jul 30, 2025
Contributor
|
🎉 This PR is included in version 1.5.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#152
This PR is for adding validation to the metrics_filter.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR is for adding validation to the metrics_filter.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers