docs: added help doc for tolerations setting #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added help doc to tolerations setting
Contributor
Author
|
/run pipeline |
aamadeuss
changed the title
Contributor
Author
|
/run pipeline |
ocofaigh
requested changes
Jul 31, 2025
Contributor
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
@aamadeuss This is not what is needed. We need to create our own markdown doc and link to it. The markdown doc should follow the same format as we have here -> https://github.com/terraform-ibm-modules/terraform-ibm-kms-all-inclusive/blob/main/solutions/fully-configurable/DA-keys.md
changed learn more link to point to new doc
Contributor
Author
|
/run pipeline |
Aashiq-J
reviewed
Aug 1, 2025
rearranged info and removed type description
fixed default code formatting
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
ocofaigh
approved these changes
Aug 7, 2025
Contributor
|
🎉 This PR is included in version 1.6.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added help doc to tolerations setting
Description
#151
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Added Learn More doc to tolerations setting.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers