Skip to content

Conversation

@arya-girish-k
Copy link
Contributor

@arya-girish-k arya-girish-k commented Oct 16, 2025

Description

Add UI regex valiadation in ibm_catalog.json.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR is to enable input validation in the UI for the instance_crn variable using the value_constraints array defined in the catalog, which the UI will use to validate user input at runtime.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k arya-girish-k marked this pull request as draft October 16, 2025 07:23
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

Tested the instance_crn regex pattern in UI:
crnv1bluemixpublicsysdig-secureceu-fr2aabac0df06b644a9cabc6e44f!
The value provided for instance_crn' is not valid

@arya-girish-k arya-girish-k marked this pull request as ready for review October 16, 2025 11:06
jor2
jor2 previously approved these changes Oct 16, 2025
ocofaigh
ocofaigh previously approved these changes Oct 16, 2025
@arya-girish-k arya-girish-k dismissed stale reviews from ocofaigh and jor2 via 91d0d93 October 17, 2025 09:53
@arya-girish-k
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit a82db00 into main Oct 17, 2025
1 of 2 checks passed
@ocofaigh ocofaigh deleted the regex-validaton branch October 17, 2025 15:02
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants