Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Apr 26, 2025

Description

the value of cloud_monitoring_instance_region_var_name was wrong so validation was failing as pods were not coming up since region was not being passed.

The diagram link was also incorrect

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh requested review from jor2 and removed request for daniel-butler-irl April 26, 2025 12:09
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

jor2
jor2 previously approved these changes Apr 26, 2025
@ocofaigh
Copy link
Contributor Author

/run pipeline

@jor2 jor2 self-requested a review April 28, 2025 08:23
@ocofaigh ocofaigh merged commit 5b6cf7e into main Apr 28, 2025
2 checks passed
@ocofaigh ocofaigh deleted the val branch April 28, 2025 09:29
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants