feat: add support for sysdig deploy params #74
Conversation
|
|
removed that null value values used variable "metrics_filter" {
type = list(object({
include = optional(string)
exclude = optional(string)
}))
description = "To filter on custom metrics, specify the IBM Cloud Monitoring metrics to include or exclude. [Learn more](https://cloud.ibm.com/docs/monitoring?topic=monitoring-change_kube_agent#change_kube_agent_inc_exc_metrics) and [here](https://github.com/terraform-ibm-modules/terraform-ibm-monitoring-agent/tree/main/solutions/fully-configurable/DA-types.md)."
default = [{ exclude = "all" }, { include = "kubernetes.*" }]
}
|
|
values passed from helm 
|
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
Why does diagram say "Existing Monitoring Agent"? The agents are deployed by the DA?
|
/run pipeline |
variables.tf
Outdated
|
|
||
| variable "access_key_secret_name" { | ||
| type = string | ||
| description = "The name of a Kubernetes or OpenShift Secret that contains the Sysdig agent access key under the key `access-key`. This variable allows you to reference an existing secret in your cluster, rather than providing the access key directly in your Terraform configuration." |
There was a problem hiding this comment.
This is still not accurate - I don't know why you are saying this. The access key is passed in as a terraform input, and that is passed to the helm chart which creates the secret. The name of that secret is the value of this input.
The description also needs to mention what the default is is left as null - perhaps we should just add a default value and match the default thats in the chart?
There was a problem hiding this comment.
I cannot find a naming value for the secret, this was renamed to existing_access_key_secret_name make it more clear with validation added that both cannot be set.
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
tolerations being applied to agent 
|
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
#65
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers