Skip to content

feat: add Logs Agent #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Oct 2, 2024
Merged

feat: add Logs Agent #368

merged 54 commits into from
Oct 2, 2024

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented Jul 26, 2024 •
edited
Loading

Description

https://github.ibm.com/goldeneye/issues/issues/9800

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7
Copy link
Member Author

iamar7 commented Jul 29, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Jul 29, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Jul 29, 2024

/run pipeline

@iamar7 iamar7 changed the title [WIP] feat: add log routing agent feat: add log routing agent Jul 29, 2024
@iamar7 iamar7 marked this pull request as ready for review July 29, 2024 06:59
@iamar7 iamar7 requested review from Aashiq-J and shemau as code owners July 29, 2024 06:59
@ocofaigh
Copy link
Contributor

We do not want to manage these helm charts in the repo. The plan is for them to be hosted publicly somewhere. We cannot proceed until that happens

@ocofaigh ocofaigh marked this pull request as draft July 30, 2024 10:34
@iamar7
Copy link
Member Author

iamar7 commented Sep 5, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 20, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 20, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 24, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

Needs to be refactored to only support sending logs to ICR directly. There is a new helm chart for that. Its going to be published to oci://icr.io/ibm/observe/logs-agent but its not there yet. Until its there, grab the internal helm chart and add it directly in the code of this repo so we can unblock ourselves here and start testing

@ocofaigh
Copy link
Contributor

@iamar7 The helm chart is now publicly available from ICR

@Aashiq-J
Copy link
Member

Aashiq-J commented Oct 1, 2024

/run pipeline

@Aashiq-J
Copy link
Member

Aashiq-J commented Oct 1, 2024

/run pipeline

@Aashiq-J
Copy link
Member

Aashiq-J commented Oct 1, 2024

/run pipeline

@Aashiq-J
Copy link
Member

Aashiq-J commented Oct 1, 2024

/run pipeline

@Aashiq-J
Copy link
Member

Aashiq-J commented Oct 1, 2024

/run pipeline

@Aashiq-J
Copy link
Member

Aashiq-J commented Oct 1, 2024

/run pipeline

ocofaigh
ocofaigh reviewed Oct 1, 2024
View reviewed changes
README.md Outdated

### Deprecated: Log Analysis

**Important:** IBM Log Analysis will be discontinued on 30 March 2025 and replaced by IBM Cloud Logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use same format / terminology as https://github.com/terraform-ibm-modules/terraform-ibm-observability-instances/blob/main/README.md ?

So maybe go with:

Important

The IBM Log Analysis service is deprecated. IBM Cloud Logs is the replacement service and is now the agent that is deployed by this module.

@ocofaigh
Copy link
Contributor

ocofaigh commented Oct 1, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Oct 2, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Oct 2, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Oct 2, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Oct 2, 2024

/run pipeline

@ocofaigh ocofaigh merged commit d5eecf8 into main Oct 2, 2024
2 checks passed
@ocofaigh ocofaigh deleted the 9800-lr branch October 2, 2024 20:48
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@Aashiq-J Aashiq-J Awaiting requested review from Aashiq-J Aashiq-J is a code owner

@shemau shemau Awaiting requested review from shemau shemau is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iamar7 @ocofaigh @Aashiq-J @terraform-ibm-modules-ops