-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add priorityClass and maxUnavailable to sysdig-agent helm chart #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| metadata: | ||
| name: "{{ .Values.metadata.name }}-ds-priority" | ||
| namespace: {{ .Release.Namespace }} | ||
| value: 1000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think the priority should be lower than logging so any errors are logged? Maybe it doesn't matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good question and I was not sure myself about the correct priority. I'm fine with lowering it a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shemau any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kulmannf I think set it to 999999 so it's right after logs priority-wise. It probably doesn't make too much of a difference anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniel-butler-irl Updated the value to 999999
|
/run pipeline |
|
🎉 This PR is included in version 1.29.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This PR contains two changes that help us in our production environments:
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers