Skip to content

feat: Add priorityClass and maxUnavailable to sysdig-agent helm chart #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2024
Merged

feat: Add priorityClass and maxUnavailable to sysdig-agent helm chart #398

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5777e4b
feat: Add priorityClass to sysdig helm chart
kulmannf Sep 25, 2024
49ea5c4
feat: Configure maxUnavailable to 25% for sysdig-agent
kulmannf Sep 26, 2024
4db8290
Change sysdig priority value to 999999
kulmannf Sep 27, 2024
fd20acb
Merge branch 'main' into main
daniel-butler-irl Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions chart/sysdig-agent/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ spec:
app: "{{ .Values.metadata.name }}"
updateStrategy:
type: RollingUpdate
rollingUpdate:
maxUnavailable: 25%
template:
metadata:
labels:
Expand Down Expand Up @@ -86,6 +88,7 @@ spec:
{{- end}}
# The following line is necessary for RBAC
serviceAccountName: "{{ .Values.metadata.name }}"
priorityClassName: "{{ .Values.metadata.name }}-ds-priority"
terminationGracePeriodSeconds: 5
containers:
- name: "{{ .Values.metadata.name }}"
Expand Down
9 changes: 9 additions & 0 deletions chart/sysdig-agent/templates/priorityclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
name: "{{ .Values.metadata.name }}-ds-priority"
namespace: {{ .Release.Namespace }}
value: 1000000
Copy link
Contributor

@daniel-butler-irl daniel-butler-irl Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the priority should be lower than logging so any errors are logged? Maybe it doesn't matter?

Copy link
Contributor Author

@kulmannf kulmannf Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question and I was not sure myself about the correct priority. I'm fine with lowering it a bit

Copy link
Contributor

@daniel-butler-irl daniel-butler-irl Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shemau any thoughts here?

Copy link
Contributor

@daniel-butler-irl daniel-butler-irl Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kulmannf I think set it to 999999 so it's right after logs priority-wise. It probably doesn't make too much of a difference anyway

Copy link
Contributor Author

@kulmannf kulmannf Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-butler-irl Updated the value to 999999

preemptionPolicy: PreemptLowerPriority
globalDefault: false
description: "Sysdig Agent"