Skip to content

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented Oct 8, 2024

Description

https://github.ibm.com/GoldenEye/issues/issues/10839

Release required?

This release adds a validation to make sure there are no spaces in cloud_monitoring_agent_tags.

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7 iamar7 requested review from Aashiq-J and shemau as code owners October 8, 2024 13:24
@iamar7
Copy link
Member Author

iamar7 commented Oct 8, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Oct 8, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Oct 8, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Oct 8, 2024

/run pipeline

Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Screenshot 2024-10-09 at 2 37 29 PM

@ocofaigh ocofaigh merged commit 9d46d7f into main Oct 9, 2024
2 checks passed
@ocofaigh ocofaigh deleted the 10839-space branch October 9, 2024 10:15
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.30.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants