Skip to content

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Oct 28, 2024

Description

Issue: https://github.ibm.com/GoldenEye/issues/issues/11264

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J Aashiq-J requested a review from shemau as a code owner October 28, 2024 11:40
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

                              - tolerationSeconds = null
                              - value             = null
                            },
                        ]
                    }
                )
              - version        = "0.1.0"
                # (2 unchanged attributes hidden)
            },
        ] -> (known after apply)
        name                       = "sysdig-agent"
      ~ values                     = [
            # (1 unchanged element hidden)
            <<-EOT
                "tolerations":
                - "effect": null
                  "key": null
                  "operator": "Exists"
                  "tolerationSeconds": null
                  "value": null
                - "effect": "NoSchedule"
                  "key": "node-role.kubernetes.io/master"
                  "operator": "Exists"
                  "tolerationSeconds": null
                  "value": null
            EOT,
          + <<-EOT
                "container_filter":
                - "name": "kube-system"
                  "parameter": "kubernetes.namespace.name"
                  "type": "exclude"
            EOT,
        ]
        # (25 unchanged attributes hidden)

        # (8 unchanged blocks hidden)
    }

Cloud monitoring agent will add this values which is causing the upgrade test to fail.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can you add the release type and release notes to the description.

@Aashiq-J Aashiq-J merged commit fb04b92 into main Oct 30, 2024
2 checks passed
@Aashiq-J Aashiq-J deleted the container branch October 30, 2024 04:54
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants