Merge branch 'main' of https://github.com/terraform-ibm-modules/terraform-ibm-observability-da into addon-poc

Author: daniel-butler-irl

.secrets.baseline

@@ -3,7 +3,7 @@
     "files": "go.sum|^.secrets.baseline$",
     "lines": null
   },
-  "generated_at": "2023-12-10T06:39:44Z",
+  "generated_at": "2023-12-12T06:39:44Z",
   "plugins_used": [
     {
       "name": "AWSKeyDetector"

README.md

@@ -6,11 +6,15 @@
 [![Renovate enabled](https://img.shields.io/badge/renovate-enabled-brightgreen.svg)](https://renovatebot.com/)
 [![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
 
+> [!IMPORTANT]
+> The IBM Log Analysis and IBM Cloud Activity Tracker services are deprecated. IBM Cloud Logs is the replacement service. This module will be updated to provision the new services before the end of support in March 2025.
+
 This repository contains the following infrastructure as code solutions:
 - [IBM Cloud Observability instances solution](./solutions/instances)
 - [IBM Cloud Observability agents solution](./solutions/agents)
 
-**NB:** These solutions are not intended to be called by one or more other modules since they contain a provider configurations, meaning they are not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers)
+> [!NOTE]
+> These solutions are not intended to be called by one or more other modules because they contain a provider configurations. They are not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers).
 
 <!-- Leave this section as is so that your module has a link to local development environment set up steps for contributors to follow -->
 ## Contributing

common-dev-assets

@@ -3,7 +3,7 @@ version: "v1"
 CRA_TARGETS:
   - CRA_TARGET: "solutions/instances"
     CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json"
-    PROFILE_ID: "bfacb71d-4b84-41ac-9825-e8a3a3eb7405" # SCC profile ID (currently set to IBM Cloud Framework for Financial Services 1.6.0 profile).
+    PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3"  # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
     CRA_ENVIRONMENT_VARIABLES:
-        TF_VAR_resource_group_name: "test"
-        TF_VAR_existing_kms_instance_crn: "XXXX:hs-crypto:XXXXXXX:XXXXX:XXXXX"
+      TF_VAR_resource_group_name: "test"
+      TF_VAR_existing_kms_instance_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::"

cra-config.yaml

@@ -1,3 +1,22 @@
 {
-    "scc_rules": []
+    "scc_rules": [
+        {
+            "scc_rule_id": "rule-4d86c074-097e-4ff3-a763-ccff128388e2",
+            "description": "Check whether multifactor authentication (MFA) is enabled at the account level",
+            "ignore_reason": "We have added an account level data lookup. Since we do not create any account setting in this DA, it can be ignored",
+            "is_valid": true
+        },
+        {
+            "scc_rule_id": "rule-0704e840-e443-4781-b9be-ec57469d09c1",
+            "description": "Check whether permissions for API key creation are limited and configured in IAM settings for the account owner",
+            "ignore_reason": "We have added an account level data lookup. Since we do not create any account setting in this DA, it can be ignored",
+            "is_valid": true
+        },
+        {
+            "scc_rule_id": "rule-0244c010-fde6-4db3-95aa-8952bd292ac3",
+            "description": "Check whether permissions for service ID creation are limited and configured in IAM settings for the account owner",
+            "ignore_reason": "We have added an account level data lookup. Since we do not create any account setting in this DA, it can be ignored",
+            "is_valid": true
+        }
+    ]
 }