feat: enable_platform_metrics input now defaults to false by default. management_endpoint_type_for_bucket now defaults to direct by default. (#442)

Co-authored-by: Conall Ó Cofaigh <[email protected]>

Author: alex-reiff

solutions/instances/variables.tf

@@ -283,7 +283,7 @@ variable "cloud_monitoring_tags" {
 variable "enable_platform_metrics" {
   type        = bool
   description = "When set to `true`, the IBM Cloud Monitoring instance collects the platform metrics."
-  default     = true
+  default     = false
 }
 
 ########################################################################################################################
@@ -500,7 +500,7 @@ variable "skip_at_cos_auth_policy" {
 variable "management_endpoint_type_for_bucket" {
   description = "The type of endpoint for the IBM Terraform provider to use to manage Cloud Object Storage buckets (`public`, `private`, or `direct`). If you are using a private endpoint, make sure that you enable virtual routing and forwarding (VRF) in your account, and that the Terraform runtime can access the IBM Cloud Private network."
   type        = string
-  default     = "private"
+  default     = "direct"
   validation {
     condition     = contains(["public", "private", "direct"], var.management_endpoint_type_for_bucket)
     error_message = "The specified `management_endpoint_type_for_bucket` is not valid. Specify a valid type of endpoint for the IBM Terraform provider to use to manage Cloud Object Storage buckets."

tests/pr_test.go

@@ -321,7 +321,7 @@ func TestRunExistingResourcesInstancesSchematics(t *testing.T) {
 			{Name: "existing_cloud_logs_metrics_bucket_endpoint", Value: terraform.Output(t, existingTerraformOptions, "metrics_bucket_endpoint"), DataType: "string"},
 			{Name: "existing_en_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "en_crn_1"), DataType: "string"},
 			{Name: "prefix", Value: options.Prefix, DataType: "string"},
-			{Name: "management_endpoint_type_for_bucket", Value: "private", DataType: "string"},
+			{Name: "management_endpoint_type_for_bucket", Value: "direct", DataType: "string"},
 			{Name: "provider_visibility", Value: "public", DataType: "string"},
 			{Name: "enable_platform_metrics", Value: false, DataType: "bool"},
 			{Name: "cloud_logs_existing_en_instances", Value: cloud_logs_existing_en_instances, DataType: "list(object)"},
@@ -358,7 +358,7 @@ func TestRunExistingResourcesInstancesSchematics(t *testing.T) {
 			{Name: "resource_group_name", Value: terraform.Output(t, existingTerraformOptions, "resource_group_name"), DataType: "string"},
 			{Name: "kms_endpoint_type", Value: "private", DataType: "string"},
 			{Name: "existing_cos_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "cos_crn"), DataType: "string"},
-			{Name: "management_endpoint_type_for_bucket", Value: "private", DataType: "string"},
+			{Name: "management_endpoint_type_for_bucket", Value: "direct", DataType: "string"},
 			{Name: "enable_platform_metrics", Value: false, DataType: "bool"},
 			{Name: "existing_kms_instance_crn", Value: permanentResources["hpcs_south_crn"], DataType: "string"},
 			{Name: "existing_cos_kms_key_crn", Value: permanentResources["hpcs_south_root_key_crn"], DataType: "string"},