-
Notifications
You must be signed in to change notification settings - Fork 1
Description
The Observability agents DA has support to pass wait_till and wait_till_timeout to the ibm_container_vpc_cluster and ibm_container_cluster data lookups done in the code. This allows consumers to allow the code to wait until a cluster is ready before attempting to connect to it.
The problem is, the observability-agents module that the DA calls also has ibm_container_vpc_cluster and ibm_container_cluster data lookups and since these do not have support to pass wait_till and wait_till_timeout to them, they execute straight away in the DA, and can time out if the cluster has not come up in time.
To fix this, the module needs to be updated to add wait_till and wait_till_timeout support to the ibm_container_vpc_cluster and ibm_container_cluster data lookups, and then the DA needs to be updated to pass those values down to the module.
NOTE: There is also a ibm_container_cluster_config data lookup in the module. That will need to be updated to depend on the ibm_container_vpc_cluster and ibm_container_cluster data lookups. This can be achieved by doing an implicit dependency by passing the output of the data lookup for the cluster ID instead of using the input variable. EG:
- Update this line to:
cluster_name_id = var.is_vpc_cluster ? data.ibm_container_vpc_cluster.cluster[0].name : data.ibm_container_cluster.cluster[0].name