Skip to content

chore: lock into exact ocp version in asic example#104

Merged
ocofaigh merged 1 commit intomainfrom
basic-ex
Feb 27, 2026
Merged

chore: lock into exact ocp version in asic example#104
ocofaigh merged 1 commit intomainfrom
basic-ex

Conversation

@ocofaigh
Copy link
Contributor

Description

The addon versions are hard coded in the basic example main.tf, meaning if user changes the value of ocp_version, the example could break as it may not support the hard coded addon version. In this PR I am removing ocp_version input from the example and also hard coding it in main.tf. Internal automation will then be used to update OCP version and addons version so they stay up to date.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh merged commit 9cd930a into main Feb 27, 2026
@ocofaigh ocofaigh deleted the basic-ex branch February 27, 2026 10:59
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants