fix: upgrade secret manager module versions (#848)

surajsbharadwaj · web-flow · commit d64f0ef0f71e · 2024-05-26T17:06:58.000+02:00
diff --git a/ibm_catalog.json b/ibm_catalog.json
@@ -257,11 +257,11 @@
                         {
                             "key": "existing_sm_instance_region",
                             "type": "string",
-                            "default_value": "null",
+                            "default_value": "__NULL__",
                             "options": [
                                 {
                                     "displayname": "Null",
-                                    "value": "null"
+                                    "value": "__NULL__"
                                 },
                                 {
                                     "displayname": "au-syd",
@@ -820,11 +820,11 @@
                         {
                             "key": "existing_sm_instance_region",
                             "type": "string",
-                            "default_value": "null",
+                            "default_value": "__NULL__",
                             "options": [
                                 {
                                     "displayname": "Null",
-                                    "value": "null"
+                                    "value": "__NULL__"
                                 },
                                 {
                                     "displayname": "au-syd",
diff --git a/modules/powervs-vpc-landing-zone/README.md b/modules/powervs-vpc-landing-zone/README.md
@@ -101,11 +101,11 @@ Creates VPC Landing Zone | Performs VPC VSI OS Config | Creates PowerVS Infrastr
 |------|--------|---------|
 | <a name="module_client_to_site_vpn"></a> [client\_to\_site\_vpn](#module\_client\_to\_site\_vpn) | terraform-ibm-modules/client-to-site-vpn/ibm | 1.7.10 |
 | <a name="module_configure_network_services"></a> [configure\_network\_services](#module\_configure\_network\_services) | ./submodules/ansible | n/a |
-| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 5.22.1 |
+| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 5.23.0 |
 | <a name="module_powervs_workspace"></a> [powervs\_workspace](#module\_powervs\_workspace) | terraform-ibm-modules/powervs-workspace/ibm | 2.0.0 |
-| <a name="module_private_secret_engine"></a> [private\_secret\_engine](#module\_private\_secret\_engine) | terraform-ibm-modules/secrets-manager-private-cert-engine/ibm | 1.2.2 |
-| <a name="module_secrets_manager_group"></a> [secrets\_manager\_group](#module\_secrets\_manager\_group) | terraform-ibm-modules/secrets-manager-secret-group/ibm | 1.1.4 |
-| <a name="module_secrets_manager_private_certificate"></a> [secrets\_manager\_private\_certificate](#module\_secrets\_manager\_private\_certificate) | terraform-ibm-modules/secrets-manager-private-cert/ibm | 1.1.3 |
+| <a name="module_private_secret_engine"></a> [private\_secret\_engine](#module\_private\_secret\_engine) | terraform-ibm-modules/secrets-manager-private-cert-engine/ibm | 1.3.1 |
+| <a name="module_secrets_manager_group"></a> [secrets\_manager\_group](#module\_secrets\_manager\_group) | terraform-ibm-modules/secrets-manager-secret-group/ibm | 1.2.1 |
+| <a name="module_secrets_manager_private_certificate"></a> [secrets\_manager\_private\_certificate](#module\_secrets\_manager\_private\_certificate) | terraform-ibm-modules/secrets-manager-private-cert/ibm | 1.2.1 |
 | <a name="module_vpc_file_share_alb"></a> [vpc\_file\_share\_alb](#module\_vpc\_file\_share\_alb) | ./submodules/fileshare-alb | n/a |
 
 ### Resources
diff --git a/modules/powervs-vpc-landing-zone/client2sitevpn.tf b/modules/powervs-vpc-landing-zone/client2sitevpn.tf
@@ -72,7 +72,7 @@ resource "ibm_resource_instance" "secrets_manager" {
 # Configure private cert engine if provisioning a new SM instance
 module "private_secret_engine" {
   source     = "terraform-ibm-modules/secrets-manager-private-cert-engine/ibm"
-  version    = "1.2.2"
+  version    = "1.3.1"
   providers  = { ibm = ibm.ibm-sm }
   count      = var.client_to_site_vpn.enable && var.existing_sm_instance_guid == null ? 1 : 0
   depends_on = [ibm_resource_instance.secrets_manager]
@@ -89,7 +89,7 @@ module "private_secret_engine" {
 # Create a secret group to place the certificate in
 module "secrets_manager_group" {
   source    = "terraform-ibm-modules/secrets-manager-secret-group/ibm"
-  version   = "1.1.4"
+  version   = "1.2.1"
   providers = { ibm = ibm.ibm-sm }
   count     = var.client_to_site_vpn.enable ? 1 : 0
 
@@ -103,7 +103,7 @@ module "secrets_manager_group" {
 # Create private cert to use for VPN server
 module "secrets_manager_private_certificate" {
   source     = "terraform-ibm-modules/secrets-manager-private-cert/ibm"
-  version    = "1.1.3"
+  version    = "1.2.1"
   providers  = { ibm = ibm.ibm-sm }
   count      = var.client_to_site_vpn.enable ? 1 : 0
   depends_on = [module.private_secret_engine]
diff --git a/modules/powervs-vpc-landing-zone/main.tf b/modules/powervs-vpc-landing-zone/main.tf
@@ -4,7 +4,7 @@
 
 module "landing_zone" {
   source    = "terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module"
-  version   = "5.22.1"
+  version   = "5.23.0"
   providers = { ibm = ibm.ibm-is }
 
   ssh_public_key       = var.ssh_public_key
@@ -27,7 +27,7 @@ module "vpc_file_share_alb" {
   file_share_name               = "${var.prefix}-file-share-nfs"
   file_share_size               = var.nfs_server_config.size
   file_share_iops               = var.nfs_server_config.iops
-  file_share_mount_target_name  = "nfs"
+  file_share_mount_target_name  = "${var.prefix}-nfs"
   file_share_subnet_id          = [for subnet in module.landing_zone.subnet_data : subnet.id if subnet.name == "${var.prefix}-edge-vsi-edge-zone-1"][0]
   file_share_security_group_ids = [for security_group in module.landing_zone.vpc_data[0].vpc_data.security_group : security_group.group_id if security_group.group_name == "network-services-sg"]
   alb_name                      = "${var.prefix}-file-share-alb"
diff --git a/reference-architectures/extension/deploy-arch-ibm-pvs-inf-extension.md b/reference-architectures/extension/deploy-arch-ibm-pvs-inf-extension.md
@@ -1,7 +1,7 @@
 ---
 copyright:
   years: 2024
-lastupdated: "2024-05-24"
+lastupdated: "2024-05-26"
 keywords:
 subcollection: deployable-reference-architectures
 authors:
@@ -15,7 +15,7 @@ use-case: ITServiceManagement
 industry: Technology
 compliance: SAPCertified
 content-type: reference-architecture
-version: v5.1.1
+version: v5.1.2
 
 ---
 
@@ -27,7 +27,7 @@ version: v5.1.1
 {: toc-industry="Technology"}
 {: toc-use-case="ITServiceManagement"}
 {: toc-compliance="SAPCertified"}
-{: toc-version="5.1.1"}
+{: toc-version="5.1.2"}
 
 The Power Virtual Server with VPC landing zone as variation 'Extend Power Virtual Server with VPC landing zone' creates an additional Power Virtual Server workspace and connects it with the already created Power Virtual Server with VPC landing zone. It builds on the existing Power Virtual Server with VPC landing zone deployed as a variation 'Create a new architecture'.
 
diff --git a/reference-architectures/full-stack/deploy-arch-ibm-pvs-inf-full-stack.md b/reference-architectures/full-stack/deploy-arch-ibm-pvs-inf-full-stack.md
@@ -1,7 +1,7 @@
 ---
 copyright:
   years: 2024
-lastupdated: "2024-05-24"
+lastupdated: "2024-05-26"
 keywords:
 subcollection: deployable-reference-architectures
 authors:
@@ -15,7 +15,7 @@ use-case: ITServiceManagement
 industry: Technology
 compliance: SAPCertified
 content-type: reference-architecture
-version: v5.1.1
+version: v5.1.2
 
 ---
 
@@ -27,7 +27,7 @@ version: v5.1.1
 {: toc-industry="Technology"}
 {: toc-use-case="ITServiceManagement"}
 {: toc-compliance="SAPCertified"}
-{: toc-version="5.1.1"}
+{: toc-version="5.1.2"}
 
 The PowerVS workspace deployment of the Power Virtual Server with VPC landing zone creates VPC services and a Power Virtual Server workspace and interconnects them.
 
diff --git a/reference-architectures/import-workspace/deploy-arch-ibm-pvs-inf-import-workspace.md b/reference-architectures/import-workspace/deploy-arch-ibm-pvs-inf-import-workspace.md
@@ -1,7 +1,7 @@
 ---
 copyright:
   years: 2024
-lastupdated: "2024-05-24"
+lastupdated: "2024-05-26"
 keywords:
 subcollection: deployable-reference-architectures
 authors:
@@ -15,7 +15,7 @@ use-case: ITServiceManagement
 industry: Technology
 compliance:
 content-type: reference-architecture
-version: v5.1.1
+version: v5.1.2
 
 ---
 
diff --git a/reference-architectures/quickstart/deploy-arch-ibm-pvs-inf-quickstart.md b/reference-architectures/quickstart/deploy-arch-ibm-pvs-inf-quickstart.md
@@ -1,7 +1,7 @@
 ---
 copyright:
   years: 2024
-lastupdated: "2024-05-24"
+lastupdated: "2024-05-26"
 keywords:
 subcollection: deployable-reference-architectures
 authors:
@@ -16,7 +16,7 @@ use-case: ITServiceManagement
 industry: Technology
 compliance:
 content-type: reference-architecture
-version: v5.1.1
+version: v5.1.2
 
 ---
 
@@ -28,7 +28,7 @@ version: v5.1.1
 {: toc-industry="Technology"}
 {: toc-use-case="ITServiceManagement"}
 {: toc-compliance=""}
-{: toc-version="5.1.1"}
+{: toc-version="5.1.2"}
 
 Quickstart deployment of the Power Virtual Server with VPC landing zone creates VPC services, a Power Virtual Server workspace, and interconnects them. It also deploys a Power Virtual Server of chosen T-shirt size or custom configuration. Supported Os are Aix, IBM i, and Linux images.
 

Original file line number	Diff line number	Diff line change
`@@ -257,11 +257,11 @@`
`257`	`257`	`{`
`258`	`258`	`"key": "existing_sm_instance_region",`
`259`	`259`	`"type": "string",`
`260`		`- "default_value": "null",`
	`260`	`+ "default_value": "__NULL__",`
`261`	`261`	`"options": [`
`262`	`262`	`{`
`263`	`263`	`"displayname": "Null",`
`264`		`- "value": "null"`
	`264`	`+ "value": "__NULL__"`
`265`	`265`	`},`
`266`	`266`	`{`
`267`	`267`	`"displayname": "au-syd",`
`@@ -820,11 +820,11 @@`
`820`	`820`	`{`
`821`	`821`	`"key": "existing_sm_instance_region",`
`822`	`822`	`"type": "string",`
`823`		`- "default_value": "null",`
	`823`	`+ "default_value": "__NULL__",`
`824`	`824`	`"options": [`
`825`	`825`	`{`
`826`	`826`	`"displayname": "Null",`
`827`		`- "value": "null"`
	`827`	`+ "value": "__NULL__"`
`828`	`828`	`},`
`829`	`829`	`{`
`830`	`830`	`"displayname": "au-syd",`