feat: remove stock catalog image import support #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

surajsbharadwaj merged 25 commits into main from image

May 7, 2025

Contributor

surajsbharadwaj commented May 6, 2025 •

edited

Loading

Description

Changed defaults for standard and quickstart (reorderd)
Changed the variation name: Added Landscape based on Arnolds decision
Add more output attributes for scc and monitoring
Removed the powervs_image import (not importing ´the images anymore)
Fixes the deployments for sap profile t-shirt : either ush1-4x256 or sh2-4x256
Hot fix for RHEL subscription on Intel VSI which fixes Broken pipe error
Remove import variation completely

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

terraform-ibm-modules-ops and others added 11 commits

May 3, 2025 09:29


          chore(deps): update terraform-module

317131d


          chore(deps): update ci dependencies

656f748


          feat: remove stock images support

c0861bb

SKIP UPGRADE TEST: Breaking change remove stock image import


          Merge remote-tracking branch 'origin/renovate/terraform-module' into …

be9c87e

…renovate/ci-dependencies


          Merge remote-tracking branch 'origin/renovate/ci-dependencies' into i…

779ba89

…mage


          feat: remove stock images support

0a11c76

SKIP UPGRADE TEST: Breaking change auto stock image import


          chore: upgrade module

44b4bad

SKIP UPGRADE TEST: Breaking change auto stock image import


          chore: upgrade module

12c9ac5

SKIP UPGRADE TEST: Breaking change auto stock image import


          docs: readme for custom images

640dc92

SKIP UPGRADE TEST: Breaking change auto stock image import


          fix: enhance scc and wp outputs

b66a690

SKIP UPGRADE TEST: Breaking change auto stock image import


          chore: upgrade module

d9b578c

SKIP UPGRADE TEST: Breaking change auto stock image import

surajsbharadwaj requested review from ludwig-mueller and stafaniasaju as code owners

May 6, 2025 10:23

surajsbharadwaj marked this pull request as draft

May 6, 2025 10:23

surajsbharadwaj marked this pull request as ready for review

May 6, 2025 10:25

Contributor Author

surajsbharadwaj commented May 6, 2025

/run pipeline

1 similar comment

Contributor Author

surajsbharadwaj commented May 6, 2025

/run pipeline


          chore: change location

44a6a72

SKIP UPGRADE TEST: Breaking change auto stock image import

Contributor Author

surajsbharadwaj commented May 6, 2025

/run pipeline

Contributor Author

surajsbharadwaj commented May 6, 2025

@ludwig-mueller and @stafaniasaju checks passed. Review , feedback required. Thanks


          chore: rearrange defaults

01bf5db

SKIP UPGRADE TEST: Breaking change auto stock image import

Contributor Author

surajsbharadwaj commented May 6, 2025

/run pipeline


          docs: rename solution

9098a15

SKIP UPGRADE TEST: Breaking change auto stock image import

Contributor Author

surajsbharadwaj commented May 6, 2025

/run pipeline

surajsbharadwaj added 2 commits

May 6, 2025 22:44


          chore: rearrange defaults

10505a6

SKIP UPGRADE TEST: Breaking change auto stock image import


          fix: reboot

d1fe43a

SKIP UPGRADE TEST: Breaking change auto stock image import

Contributor Author

surajsbharadwaj commented May 6, 2025

/run pipeline

ludwig-mueller and others added 3 commits

May 7, 2025 11:51


          chore: remove unused variable scc wp guid from template

7670e54


          fix: hotfix subscription-manager broken pipe error

e131094


          fix: remove import variation

14d4497

SKIP UPGRADE TEST: Breaking change auto stock image import

Contributor Author

surajsbharadwaj commented May 7, 2025

/run pipeline

ludwig-mueller previously approved these changes

View reviewed changes

stafaniasaju reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved


          docs: update readme

482aea5

surajsbharadwaj dismissed ludwig-mueller’s stale review via

482aea5

May 7, 2025 12:14

surajsbharadwaj requested review from ludwig-mueller and stafaniasaju

May 7, 2025 12:20


          chore: rename variation

e72ba19

stafaniasaju reviewed

View reviewed changes

solutions/standard-plus-vsi/README.md Outdated Show resolved Hide resolved

surajsbharadwaj added 2 commits

May 7, 2025 14:40


          chore: implicit destroy for ws and subnets

a68f7e0


          docs: update readme

52ba62e

surajsbharadwaj requested a review from stafaniasaju

May 7, 2025 12:42

stafaniasaju reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

stafaniasaju reviewed

View reviewed changes

modules/powervs-vpc-landing-zone/README.md Outdated Show resolved Hide resolved


          docs: update readme description

1ccbd28

surajsbharadwaj requested a review from stafaniasaju

May 7, 2025 13:41


          docs: update readme description

3f5b8b3

stafaniasaju approved these changes

View reviewed changes

surajsbharadwaj merged commit f09e7b3 into main

surajsbharadwaj deleted the image branch

May 7, 2025 15:10

Contributor

terraform-ibm-modules-ops commented May 7, 2025

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

GitHub release
v8.4.0

Your semantic-release bot 📦🚀

terraform-ibm-modules-ops added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels