Skip to content

Conversation

@surajsbharadwaj
Copy link
Contributor

@surajsbharadwaj surajsbharadwaj commented May 19, 2025

Description

reuse secrets manager instance along with creating new certificates and templates
Remove certificate_template_name support

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@surajsbharadwaj
Copy link
Contributor Author

/run pipeline

@surajsbharadwaj surajsbharadwaj changed the title fix: reuse secrets manager instance along with creating new certificates or reuse existing templates fix: reuse secrets manager instance along with creating new certificates and templates May 19, 2025
@surajsbharadwaj
Copy link
Contributor Author

/run pipeline

SKIP UPGRADE TEST: variable removed
@surajsbharadwaj
Copy link
Contributor Author

/run pipeline

SKIP UPGRADE TEST: variable removed
@surajsbharadwaj
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@stafaniasaju stafaniasaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surajsbharadwaj surajsbharadwaj merged commit 024acf8 into main May 20, 2025
1 of 2 checks passed
@surajsbharadwaj surajsbharadwaj deleted the sm branch May 20, 2025 11:51
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants