-
Notifications
You must be signed in to change notification settings - Fork 11
feat: split monitoring instance and host #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't expose monitoring host for any of the solutions. We deploy in SAP solutions only, we don't want to offer in quickstart, architecture diagram must be updated,(remove the monitoring host from all architectures)
|
Just to confirm, we're also removing it from standard variation because the SAP solutions are becoming one click solutions and won't use standard as a pre-req anymore? |
|
If that's the case, I also don't see a point for keeping |
|
/run pipeline |
surajsbharadwaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes
|
🎉 This PR is included in version 10.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers