Skip to content

Conversation

@ludwig-mueller
Copy link
Member

Description

  • improve ssh key variable description
  • catalog manifest improvements
  • architecture diagram add OpenShift icon

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ludwig-mueller ludwig-mueller changed the title Ocp fixes fix: ocp variation improvements Oct 8, 2025
@ludwig-mueller
Copy link
Member Author

/run pipeline

Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toc version, should match planned release version: Must be changed under ref arch folders and also in the ibmcatalig.json file for images

  1. since you have changed the type to string are you sure that handling of this text happens correctly inside the submodule and is written into the config file correctly ?

surajsbharadwaj
surajsbharadwaj previously approved these changes Oct 8, 2025
Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder names and file names for ref arch must be changed from Standard Openshift to Quickstart openshift ?

@ludwig-mueller
Copy link
Member Author

/run pipeline

@ludwig-mueller ludwig-mueller merged commit 2df761d into main Oct 9, 2025
2 checks passed
@ludwig-mueller ludwig-mueller deleted the ocp-fixes branch October 9, 2025 09:10
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants