-
Notifications
You must be signed in to change notification settings - Fork 11
fix: ocp variation improvements #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
surajsbharadwaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toc version, should match planned release version: Must be changed under ref arch folders and also in the ibmcatalig.json file for images
- since you have changed the type to string are you sure that handling of this text happens correctly inside the submodule and is written into the config file correctly ?
reference-architectures/standard-openshift/deploy-arch-ibm-pvs-inf-standard-openshift.svg
Show resolved
Hide resolved
surajsbharadwaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folder names and file names for ref arch must be changed from Standard Openshift to Quickstart openshift ?
|
/run pipeline |
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers