Skip to content

Conversation

@ludwig-mueller
Copy link
Member

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ludwig-mueller
Copy link
Member Author

/run pipeline

Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't expose monitoring host for any of the solutions. We deploy in SAP solutions only, we don't want to offer in quickstart, architecture diagram must be updated,(remove the monitoring host from all architectures)

@ludwig-mueller
Copy link
Member Author

Just to confirm, we're also removing it from standard variation because the SAP solutions are becoming one click solutions and won't use standard as a pre-req anymore?

@ludwig-mueller
Copy link
Member Author

If that's the case, I also don't see a point for keeping existing_monitoring_instance_crn exposed in the solutions

@ludwig-mueller
Copy link
Member Author

/run pipeline

Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes

@surajsbharadwaj surajsbharadwaj merged commit 6f5ef36 into main Oct 20, 2025
@surajsbharadwaj surajsbharadwaj deleted the split_monitoring branch October 20, 2025 12:47
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants