chore: VPC Landingzone and SAP HANA in one click

[tripan27]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[surajsbharadwaj]

1. Small refactoring. Many locals not required .
2. All lines in images.tf which are commented must be uncommented

[surajsbharadwaj]

@tripan27 Check the precommits and fix it:

1. ibm_catalog.json
   Validate ibm_catalog.json file............................................Failed

• hook id: validate_ibm_catalog_json
• exit code: 1

product_label: 'Power Virtual Server for SAP HANA'
flavor_label: 'SAP ready PowerVS'
working_directory: 'solutions/ibm-catalog/sap-ready-to-go':

• the following inputs should be defined in ibm_catalog.json: ['client_to_site_vpn', 'dns_forwarder_config', 'enable_monitoring', 'enable_scc_wp', 'existing_monitoring_instance_crn', 'existing_sm_instance_guid', 'existing_sm_instance_region', 'external_access_ip', 'nfs_server_config', 'powervs_backup_network', 'powervs_custom_image_cos_configuration', 'powervs_custom_image_cos_service_credentials', 'powervs_custom_images', 'powervs_management_network', 'powervs_resource_group_name', 'sm_service_plan', 'ssh_public_key', 'tags', 'vpc_intel_images']
• the following inputs should not be defined in ibm_catalog.json: ['prerequisite_workspace_id']
  and

Warning: [Fixable] local.validate_images_mixed is declared but not used (terraform_unused_declarations)

on images.tf line 68:
68: validate_images_mixed = regex("^${local.images_mixed_msg}$", (local.images_mixed ? "" : local.images_mixed_msg))

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.12.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] local.validate_byol_provided is declared but not used (terraform_unused_declarations)

on images.tf line 71:
71: validate_byol_provided = regex("^${local.missing_byol_msg}$", (local.missing_byol_creds ? "" : local.missing_byol_msg))

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.12.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] local.validate_byol_and_fls is declared but not used (terraform_unused_declarations)

on images.tf line 74:
74: validate_byol_and_fls = regex("^${local.byol_and_fls_msg}$", (local.byol_and_fls ? "" : local.byol_and_fls_msg))

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.12.0/docs/rules/terraform_unused_declarations.md

[surajsbharadwaj]

@tripan27 Please check the PR here: #875

[tripan27]

Things to fix in the next commit:
•	Unused variable: variable "pi_sap_network_cidr" is declared but not used.
•	Fix location: solutions/ibm-catalog/sap-s4hana-bw4hana
•	Update required in: ibm_catalog.json → keys ['powervs_management_network', 'powervs_backup_network']

[surajsbharadwaj]

minor changes

[surajsbharadwaj]

1. resolve conflicts
2. delete e2e solution
3. update Readmes
4. Configure test to use single click solution
5. Include the catalog validation yaml file for on boarding

[surajsbharadwaj]

some more changes

[tripan27]

/run pipeline

[tripan27]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[surajsbharadwaj]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

• GitHub release
• v5.0.0

Your semantic-release bot 📦🚀