Skip to content

Conversation

@ludwig-mueller
Copy link
Member

@ludwig-mueller ludwig-mueller commented Oct 31, 2025

Description

no_proxy_host values were hardcoded to 10. network but users can specify custom subnets. Therefore, the custom subnets need to be used

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

BabithaPadiri
BabithaPadiri previously approved these changes Oct 31, 2025
Copy link

@BabithaPadiri BabithaPadiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surajsbharadwaj
Copy link
Contributor

/run pipeline

@ludwig-mueller ludwig-mueller changed the title fix: use subnet variables for no_proxy_hosts chore: use subnet variables for no_proxy_hosts Oct 31, 2025
@ludwig-mueller
Copy link
Member Author

/run pipeline

1 similar comment
@ludwig-mueller
Copy link
Member Author

/run pipeline

@ludwig-mueller
Copy link
Member Author

Rerunning since nlb creation failed. However, this test is expected to fail because the playbook values changed which will trigger a replace. Would like to see that error before merging.

@ludwig-mueller
Copy link
Member Author

Force merging. Test ran as expected.

@ludwig-mueller ludwig-mueller merged commit f3bd927 into main Nov 3, 2025
1 of 2 checks passed
@ludwig-mueller ludwig-mueller deleted the no_proxy_custom_networks branch November 3, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants