Skip to content

chore(deps): lock the DA into terraform version 1.10.5 #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

chore(deps): lock the DA into terraform version 1.10.5 #855

merged 1 commit into from
Jul 30, 2025

Conversation

@akocbek
Copy link
Contributor

@akocbek akocbek commented Jul 29, 2025 

    This PR ensures that the `ibm_catalog.json` file includes the required `terraform_version` field.

    An upcoming version of **`common-dev-assets`** will introduce an updated `pre-commit` hook that enforces this check. Applying this change now ensures compatibility with the new hook and avoids future commit failures.

@akocbek
Copy link
Contributor Author

akocbek commented Jul 29, 2025

/run pipeline

@akocbek akocbek added renovate and removed renovate labels Jul 29, 2025
@ocofaigh
Copy link
Contributor

ocofaigh commented Jul 30, 2025

@surajsbharadwaj There must be an issue in current main branch, as test failed with below error, however it has nothing to do with the changes in this PR..

        	Messages:   	Resource(s) identified to be updated 
        	            	Name: private_subnet_2
        	            	Address: module.standard.module.powervs_workspace.ibm_pi_network.private_subnet_2[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"pi_advertise":"enable","pi_arp_broadcast":"disable"}
        	            	  After: 
        	            		{"pi_advertise":null,"pi_arp_broadcast":null}

@surajsbharadwaj
Copy link
Contributor

surajsbharadwaj commented Jul 30, 2025 •
edited
Loading

@ocofaigh yes we are aware of it. Waiting for a new IBM provider release which fixes this bug. Scheduled for end of this month.
Thanks

@surajsbharadwaj surajsbharadwaj changed the title fix(deps): lock the DA into terraform version 1.10.5 chore(deps): lock the DA into terraform version 1.10.5 Jul 30, 2025
@surajsbharadwaj surajsbharadwaj merged commit 6686248 into main Jul 30, 2025
1 of 2 checks passed
@surajsbharadwaj surajsbharadwaj deleted the terraform_version_1 branch July 30, 2025 18:29
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Sep 5, 2025

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@surajsbharadwaj surajsbharadwaj surajsbharadwaj approved these changes

@stafaniasaju stafaniasaju Awaiting requested review from stafaniasaju

@ludwig-mueller ludwig-mueller Awaiting requested review from ludwig-mueller ludwig-mueller is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akocbek @ocofaigh @surajsbharadwaj @terraform-ibm-modules-ops