fix: add support for au-syd and ca-tor #341
Conversation
ocofaigh
requested review from
imprateeksh and
rajatagarwal-ibm
as code owners
|
/run pipeline |
|
It seems this DA is no longer idempotent and hence is failing the tests. I created tracking issue: #342 |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
imprateeksh
left a comment
imprateeksh
left a comment
There was a problem hiding this comment.
@ocofaigh - Provided few comments, please check once.
| resource_group_id = module.resource_group.resource_group_id | ||
| name = "${var.prefix}-es" | ||
| region = var.region | ||
| service_endpoints = "public-and-private" |
There was a problem hiding this comment.
I have seen this earlier also that a warning is shown when using public-and-private endpoint. Can check here in the test logs.
There was a problem hiding this comment.
I won't fix that yet - that can be done as part of the effort to run the tests in schematics. If I do that now, it will fail as GHA wont have access to the private enpoint
There was a problem hiding this comment.
Its not an error - its a warning
| } | ||
|
|
||
| output "kms_instance_crn" { | ||
| value = module.key_protect.key_protect_id |
There was a problem hiding this comment.
| value = module.key_protect.key_protect_id | |
| value = module.key_protect.key_protect_crn |
key protect CRN should be used as key_protect_id will provide service instance id.
There was a problem hiding this comment.
The ID and CRN are the same for Key Protect (its not guid). But I'll update anyway
|
|
||
| output "elasticsearch_crn" { | ||
| value = module.elasticsearch.crn | ||
| description = "Elasticsearch CRN." |
There was a problem hiding this comment.
small correction -
| description = "Elasticsearch CRN." | |
| description = "Elasticsearch instance CRN." |
| ImplicitRequired: false, | ||
| Region: region, | ||
| ImplicitRequired: false, | ||
| Region: region, |
There was a problem hiding this comment.
Region is fixed as us-south here. Is this ok or should we include random regions like in other repos?
There was a problem hiding this comment.
I can add this yes (but was not the goal of the PR)
|
Both Tests failed due to these errors - 
|
|
/run pipeline |
2 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers