feat: changed the default scan schedule of the DA to every 30 days (#191)

Author: ocofaigh

.secrets.baseline

@@ -3,7 +3,7 @@
     "files": "go.sum|^.secrets.baseline$",
     "lines": null
   },
-  "generated_at": "2023-12-11T06:39:44Z",
+  "generated_at": "2023-12-12T06:39:44Z",
   "plugins_used": [
     {
       "name": "AWSKeyDetector"

solutions/instances/README.md

@@ -49,7 +49,7 @@ This solution supports provisioning and configuring the following infrastructure
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_add_bucket_name_suffix"></a> [add\_bucket\_name\_suffix](#input\_add\_bucket\_name\_suffix) | Whether to add a generated 4-character suffix to the created Security and Compliance Center Object Storage bucket name. Applies only if not specifying an existing bucket. Set to `false` not to add the suffix to the bucket name in the `scc_cos_bucket_name` variable. | `bool` | `true` | no |
-| <a name="input_attachment_schedule"></a> [attachment\_schedule](#input\_attachment\_schedule) | The scanning schedule. Possible values: `daily`, `every_7_days`, `every_30_days`, `none`. | `string` | `"daily"` | no |
+| <a name="input_attachment_schedule"></a> [attachment\_schedule](#input\_attachment\_schedule) | The scanning schedule. Possible values: `daily`, `every_7_days`, `every_30_days`, `none`. | `string` | `"every_30_days"` | no |
 | <a name="input_cos_instance_access_tags"></a> [cos\_instance\_access\_tags](#input\_cos\_instance\_access\_tags) | A list of access tags to apply to the Object Storage instance. Applies only if not specifying an existing instance. | `list(string)` | `[]` | no |
 | <a name="input_cos_instance_name"></a> [cos\_instance\_name](#input\_cos\_instance\_name) | The name for the Object Storage instance. If a prefix input variable is specified, the prefix is added to the name in the `<prefix>-<name>` format. | `string` | `"base-security-services-cos"` | no |
 | <a name="input_cos_instance_tags"></a> [cos\_instance\_tags](#input\_cos\_instance\_tags) | The list of tags to add to the Object Storage instance. Applies only if not specifying an existing instance. | `list(string)` | `[]` | no |

solutions/instances/catalogValidationValues.json.template

@@ -1,6 +1,5 @@
 {
   "ibmcloud_api_key": $VALIDATION_APIKEY,
   "resource_group_name": $PREFIX,
-  "existing_kms_instance_crn": $HPCS_US_SOUTH_CRN,
-  "profile_attachments": "[]"
+  "existing_kms_instance_crn": $HPCS_US_SOUTH_CRN
 }

solutions/instances/variables.tf

@@ -239,7 +239,7 @@ variable "resource_groups_scope" {
 variable "attachment_schedule" {
   type        = string
   description = "The scanning schedule. Possible values: `daily`, `every_7_days`, `every_30_days`, `none`."
-  default     = "daily"
+  default     = "every_30_days"
 
   validation {
     condition     = contains(["daily", "every_7_days", "every_30_days", "none"], var.attachment_schedule)