fix(deps): add fix for Event Notifications integration<br>- bump to ibm provider version 1.76.0 (#260)

Author: ocofaigh

solutions/instances/README.md

@@ -18,7 +18,7 @@ This solution supports provisioning and configuring the following infrastructure
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.4.0 |
-| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | 1.75.2 |
+| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | 1.76.0 |
 | <a name="requirement_time"></a> [time](#requirement\_time) | 0.12.1 |
 
 ### Modules
@@ -42,14 +42,14 @@ This solution supports provisioning and configuring the following infrastructure
 
 | Name | Type |
 |------|------|
-| [ibm_en_subscription_email.email_subscription](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.75.2/docs/resources/en_subscription_email) | resource |
-| [ibm_en_topic.en_topic](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.75.2/docs/resources/en_topic) | resource |
-| [ibm_iam_authorization_policy.cos_kms_policy](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.75.2/docs/resources/iam_authorization_policy) | resource |
+| [ibm_en_subscription_email.email_subscription](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.76.0/docs/resources/en_subscription_email) | resource |
+| [ibm_en_topic.en_topic](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.76.0/docs/resources/en_topic) | resource |
+| [ibm_iam_authorization_policy.cos_kms_policy](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.76.0/docs/resources/iam_authorization_policy) | resource |
 | [time_sleep.wait_for_authorization_policy](https://registry.terraform.io/providers/hashicorp/time/0.12.1/docs/resources/sleep) | resource |
 | [time_sleep.wait_for_scc](https://registry.terraform.io/providers/hashicorp/time/0.12.1/docs/resources/sleep) | resource |
-| [ibm_en_destinations.en_destinations](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.75.2/docs/data-sources/en_destinations) | data source |
-| [ibm_iam_account_settings.iam_account_settings](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.75.2/docs/data-sources/iam_account_settings) | data source |
-| [ibm_resource_group.group](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.75.2/docs/data-sources/resource_group) | data source |
+| [ibm_en_destinations.en_destinations](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.76.0/docs/data-sources/en_destinations) | data source |
+| [ibm_iam_account_settings.iam_account_settings](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.76.0/docs/data-sources/iam_account_settings) | data source |
+| [ibm_resource_group.group](https://registry.terraform.io/providers/IBM-Cloud/ibm/1.76.0/docs/data-sources/resource_group) | data source |
 
 ### Inputs
 

solutions/instances/main.tf

@@ -241,24 +241,25 @@ moved {
 }
 
 module "scc" {
-  source                            = "terraform-ibm-modules/scc/ibm"
-  existing_scc_instance_crn         = var.existing_scc_instance_crn
-  version                           = "1.11.2"
-  resource_group_id                 = module.resource_group.resource_group_id
-  region                            = local.scc_instance_region
-  instance_name                     = local.scc_instance_name
-  plan                              = var.scc_service_plan
-  cos_bucket                        = local.scc_cos_bucket_name
-  cos_instance_crn                  = local.cos_instance_crn
-  en_instance_crn                   = var.existing_event_notifications_crn
-  en_source_name                    = var.event_notifications_source_name
-  en_source_description             = var.event_notifications_source_description
-  skip_cos_iam_authorization_policy = var.skip_scc_cos_iam_auth_policy
-  resource_tags                     = var.scc_instance_tags
-  attach_wp_to_scc_instance         = var.provision_scc_workload_protection && var.existing_scc_instance_crn == null
-  wp_instance_crn                   = var.provision_scc_workload_protection && var.existing_scc_instance_crn == null ? module.scc_wp[0].crn : null
-  skip_scc_wp_auth_policy           = var.skip_scc_workload_protection_iam_auth_policy
-  cbr_rules                         = var.scc_instance_cbr_rules
+  source                                 = "terraform-ibm-modules/scc/ibm"
+  existing_scc_instance_crn              = var.existing_scc_instance_crn
+  version                                = "1.11.2"
+  resource_group_id                      = module.resource_group.resource_group_id
+  region                                 = local.scc_instance_region
+  instance_name                          = local.scc_instance_name
+  plan                                   = var.scc_service_plan
+  cos_bucket                             = local.scc_cos_bucket_name
+  cos_instance_crn                       = local.cos_instance_crn
+  enable_event_notifications_integration = var.existing_event_notifications_crn == null ? false : true
+  en_instance_crn                        = var.existing_event_notifications_crn
+  en_source_name                         = var.event_notifications_source_name
+  en_source_description                  = var.event_notifications_source_description
+  skip_cos_iam_authorization_policy      = var.skip_scc_cos_iam_auth_policy
+  resource_tags                          = var.scc_instance_tags
+  attach_wp_to_scc_instance              = var.provision_scc_workload_protection && var.existing_scc_instance_crn == null
+  wp_instance_crn                        = var.provision_scc_workload_protection && var.existing_scc_instance_crn == null ? module.scc_wp[0].crn : null
+  skip_scc_wp_auth_policy                = var.skip_scc_workload_protection_iam_auth_policy
+  cbr_rules                              = var.scc_instance_cbr_rules
 }
 
 #######################################################################################################################

solutions/instances/version.tf

@@ -4,7 +4,7 @@ terraform {
   required_providers {
     ibm = {
       source  = "IBM-Cloud/ibm"
-      version = "1.75.2"
+      version = "1.76.0"
     }
     time = {
       source  = "hashicorp/time"

tests/pr_test.go

@@ -198,9 +198,8 @@ func TestRunExistingResourcesInstances(t *testing.T) {
 				"existing_cos_instance_crn":           terraform.Output(t, existingTerraformOptions, "cos_crn"),
 				"management_endpoint_type_for_bucket": "public",
 				"provider_visibility":                 "public",
-				// Temporarily removed because of provider issue: https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5890
-				// "existing_event_notifications_crn":                     terraform.Output(t, existingTerraformOptions, "en_crn"),
-				// "event_notifications_source_name":                      prefix, // This name must be unique per SCC instance that is integrated with the Event Notifications instance.
+				"existing_event_notifications_crn":    terraform.Output(t, existingTerraformOptions, "en_crn"),
+				"event_notifications_source_name":     prefix, // This name must be unique per SCC instance that is integrated with the Event Notifications instance.
 			},
 		})