fix: added validation to the DA prefix input. Prefix must begin with a lowercase letter, contain only lowercase letters, numbers, and - characters. Prefix must end with a lowercase letter or number and be 16 or fewer characters. (#224)

Author: kierramarie

solutions/instances/variables.tf

@@ -30,6 +30,15 @@ variable "prefix" {
   type        = string
   description = "The prefix to add to all resources that this solution creates. To not use any prefix value, you can set this value to `null` or an empty string."
   default     = "dev"
+  validation {
+    condition = (var.prefix == null ? true :
+      alltrue([
+        can(regex("^[a-z]{0,1}[-a-z0-9]{0,14}[a-z0-9]{0,1}$", var.prefix)),
+        length(regexall("^.*--.*", var.prefix)) == 0
+      ])
+    )
+    error_message = "Prefix must begin with a lowercase letter, contain only lowercase letters, numbers, and - characters. Prefixes must end with a lowercase letter or number and be 16 or fewer characters."
+  }
 }
 
 variable "provider_visibility" {

tests/pr_test.go

@@ -92,7 +92,7 @@ func TestRunUpgradeInstances(t *testing.T) {
 	options := testhelper.TestOptionsDefault(&testhelper.TestOptions{
 		Testing:      t,
 		TerraformDir: instanceFlavorDir,
-		Prefix:       "scc-ins-upg",
+		Prefix:       "scc-upg",
 	})
 
 	options.TerraformVars = map[string]interface{}{