Skip to content

Conversation

@Aayush-Abhyarthi
Copy link
Member

@Aayush-Abhyarthi Aayush-Abhyarthi commented Nov 15, 2024

Description

#155

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR fixes the incorrect service name and fills test gap.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

@ocofaigh The upgrade test for the advanced example is failing because of an apply on the main branch which has the incorrect serrvice name. So, should I skip this upgrade test?

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit bc4db6a into main Nov 18, 2024
2 checks passed
@ocofaigh ocofaigh deleted the issue-11573 branch November 18, 2024 09:08
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants