Skip to content

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2025
Merged

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #354

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7aff83e
chore: updating the description for existing test
Nov 19, 2025
dc27f43
Merge branch 'main' into update-scc
mounicatellabati Nov 19, 2025
1ff6514
chore: ignoring parameter cloud_monitoring_connected_instance through…
Nov 20, 2025
9ab14de
fix: update Readme.md file
Nov 20, 2025
841a47b
fix: update Readme.md file
Nov 20, 2025
261fd85
Merge branch 'main' into update-scc
mounicatellabati Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ resource "ibm_resource_instance" "scc_wp" {
location = var.region
tags = var.resource_tags
parameters = {
cloud_monitoring_connected_instance : var.cloud_monitoring_instance_crn
cloud_monitoring_connected_instance = var.cloud_monitoring_instance_crn
}
lifecycle {
Copy link
Contributor

@ocofaigh ocofaigh Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always leave a code comment as to why your adding a lifecycle ignore

ignore_changes = [
parameters["cloud_monitoring_connected_instance"]
]
}
}

Expand Down
2 changes: 1 addition & 1 deletion solutions/fully-configurable/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ variable "existing_monitoring_crn" {
type = string
nullable = true
default = null
description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create a connection between instances. Both instances must be in the same region. [Learn more](https://www.ibm.com/products/cloud-monitoring)"
description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create the connection. Once the connection is created, the Monitoring instance CRN cannot be changed. Learn more](https://www.ibm.com/products/cloud-monitoring)"
Copy link
Contributor

@ocofaigh ocofaigh Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the opening bracket

Copy link
Contributor

@ocofaigh ocofaigh Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we point to a better link - thats too generic. Is there any doc that has info abut this topic (connecting instances)


validation {
condition = anytrue([
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ variable "access_tags" {

variable "cloud_monitoring_instance_crn" {
type = string
description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create a connection between instances. Both instances must be in the same region."
description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create the connection. Once the connection is created, the Monitoring instance CRN cannot be changed."
default = null

validation {
Expand Down